Telemetry Client is not flushed on console exit

nhart12 commented 5 years ago

With a console application on dotnet core 2.2 I'm finding not all events are making it to AI. Here is a simple repro project where log is not sent :

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
     <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp2.2</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.ApplicationInsights" Version="2.9.1" />
    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="2.2.0" />
  </ItemGroup>
</Project>

And the Program.cs (Note I'm even disposing of the ServiceProvider.)

using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;

namespace ConsoleApp1
{
    class Program
    {

    static void Main(string[] args)
    {
        IServiceCollection services = new ServiceCollection();

        // Add the logging pipelines to use. We are using Application Insights only here.
        services.AddLogging(loggingBuilder =>
        {
            loggingBuilder.AddApplicationInsights("my-key");
            loggingBuilder.AddConsole();
        });

        // Build ServiceProvider.
        using (var serviceProvider = services.BuildServiceProvider())
        {
            ILogger<Program> logger = serviceProvider.GetRequiredService<ILogger<Program>>();

            logger.LogInformation("Logger is working");
        }
    }
    }
}

If I fork this library and add a telemetryClient.Flush() then my log is sent (only if I dispose the ServiceProvider). Line 108 here: https://github.com/Microsoft/ApplicationInsights-dotnet-logging/blob/develop/src/ILogger/ApplicationInsightsLoggerProvider.cs


         /// Releases unmanaged and - optionally - managed resources. 
         /// </summary>
         /// <param name="releasedManagedResources">Release managed resources.</param>
         protected virtual void Dispose(bool releasedManagedResources)
         {
             this.telemetryClient.Flush(); //Line 108 on ApplicationInsightsLoggerProvider.cs
         }