search

microsoft / ApplicationInsights-dotnet-server

Microsoft Application Insights for .NET Web Applications
https://azure.microsoft.com/services/application-insights/
133 stars 67 forks source link

fix internal error: "Failed to handle {}, id {}, error {}" #1101

Closed TimothyMothra closed 6 years ago

TimothyMothra commented 6 years ago

Our internal telemetry is getting flooded by errors with unique ids. This change is to remove this id from the error message.

AI (Internal): [Microsoft-ApplicationInsights-Extensibility-DependencyCollector] 
Failed to handle Microsoft.Azure.ServiceBus.Process.Stop event, 
id = '##################', 
error = 'System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.SamplingTelemetryProcessor.Process(ITelemetry item)
   at Microsoft.ApplicationInsights.TelemetryClient.Track(ITelemetry telemetry)
   at Microsoft.ApplicationInsights.TelemetryClient.TrackRequest(RequestTelemetry request)
   at Microsoft.ApplicationInsights.DependencyCollector.Implementation.EventHandlers.ServiceBusDiagnosticsEventHandler.OnRequest(String name, Object payload, Activity activity)
   at Microsoft.ApplicationInsights.DependencyCollector.Implementation.EventHandlers.ServiceBusDiagnosticsEventHandler.OnEvent(KeyValuePair`2 evnt, DiagnosticListener ignored)
   at Microsoft.ApplicationInsights.DependencyCollector.Implementation.DiagnosticSourceListenerBase`1.IndividualDiagnosticSourceListener.OnNext(KeyValuePair`2 evnt)'

TODO After merge to develop, need to cherry pick to master for release