search

microsoft / ApplicationInsights-dotnet-server

Microsoft Application Insights for .NET Web Applications
https://azure.microsoft.com/services/application-insights/
133 stars 67 forks source link

Added IIS application pool telemetry initializer. #1158

Closed paulomorgado closed 4 years ago

paulomorgado commented 5 years ago

Fix Issue # .

- [X] I ran Unit Tests locally. For significant contributions please make sure you have completed the following items: - [ ] Changes in public surface reviewed - [ ] Design discussion issue # - [ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue. - [ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you. If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR) - Please follow [these] (https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/develop/CONTRIBUTING.md) instructions to build and test locally.
msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

cijothomas commented 5 years ago

Thanks for your contribution!

Can you describe the problem being solved with this PR? I see that this new initializer is not added to default config, so users have to explicitly add this one. Perhaps this could be in examples repo, but i'll comment more if you can explain this in bit more detail.

paulomorgado commented 5 years ago

When there are several applications pools running on IIS physical or virtual machines, monitoring several layers of a distributed application becomes very difficult (impossible) just attaching Application Insights to the application (using the Status Monitor, for example).

Sometimes the customer can't or doesn't want to change the application code. Sometimes it's for a proof-of-concept.

cijothomas commented 5 years ago

@paulomorgado I guess this is best to be placed under examples: https://github.com/Microsoft/ApplicationInsights-Home/tree/master/Samples

paulomorgado commented 5 years ago

@cijothomas aren't examples to show how one can change her/his application to use Application Insights? What if one can't do that and still requires a cloud_RoleName?