sywhang
commented
5 years ago Other than the two comments I made above I think things look fine (from a quick glance) - Please feel free to tag me on any follow-up PRs regarding counters/EventListener and I'd be happy to help answer any questions :-)
Fix Issue #1222
Adds new Nuget package, new ITelemetryModule for collecting EventCounters.
I am working on adding Unit Tests, please review product code.
For significant contributions please make sure you have completed the following items:
[ ] Changes in public surface reviewed
[ ] Design discussion issue #
[ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
[ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you. If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)
Please follow [these] (https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/develop/CONTRIBUTING.md) instructions to build and test locally.