search

microsoft / ApplicationInsights-dotnet-server

Microsoft Application Insights for .NET Web Applications
https://azure.microsoft.com/services/application-insights/
133 stars 67 forks source link

QuickPulse threads modified to have safeguards for never throwing #1238

Closed cijothomas closed 5 years ago

cijothomas commented 5 years ago
  1. QuickPulse threads modified to have safeguards for never throwing exception.
  2. NetCore implementation moved to share same Thread based implementation as NetFramework. Previously NetCore used Task based implementation. (I believe at that time Thread package was not referred in netcore projects)

Fix Issue #1088 .

- [ ] I ran Unit Tests locally. For significant contributions please make sure you have completed the following items: - [ ] Changes in public surface reviewed - [ ] Design discussion issue # - [ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue. - [ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you. If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR) - Please follow [these] (https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/develop/CONTRIBUTING.md) instructions to build and test locally.
cijothomas commented 5 years ago

Abandoning this in favor of this: https://github.com/microsoft/ApplicationInsights-dotnet-server/pull/1246