microsoft / ApplicationInsights-dotnet-server

Microsoft Application Insights for .NET Web Applications
https://azure.microsoft.com/services/application-insights/
133 stars 67 forks source link

EventCounters are reported under PerformanceCounter as opposed to CustomMetric #1280

Closed cijothomas closed 4 years ago

cijothomas commented 4 years ago

EventCounters are currently reported with a special property "customPerfCounter"=true, which makes back end treat it as a PerformanceCounter. This logic exists in back end to maintain backward compatibility, when PerformanceCounter type was deprecated in favor of MetricTelemetry, to ensure performance counters collected by PerformanceCounterModule continues to appear in perfcounter table.

There is no backward compatibility issue with EventCounter, and it should be reported under customMetrics, like any other regular metric.

Though we just shipped the very 1st EventCounter collection module (2.11.0), I propose to fix this in 2.11.1, before bigger customer adoption.

The docs current state EventCounters appear under PerformanceCounter, and it must be corrected as well.