Adding a flag to enable/disable collection of SQL Command text

[stebet]

Adding a boolean flag to the DependencyTrackingTelemetryModule which instructs the SQL processors to enable/disable collecting SQL command text.

Also added tests to verify the functionality.

Perhaps there is a better place for that flag than on the module itself since it's propagated down to the other classes, but it made sense to put it there.

This relates to https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/980 as well as

1282

• [x] I ran Unit Tests locally.

[cijothomas]

@Dmitry-Matveev @SergeyKanzhelev I am fine with this PR changes. I could use one of your review as well especially on the part where we are changing SQL Text to be opt-in for .net core customers now.

[lmolkova]

LGTM.

regarding defaults, I suggest

• keep collecting SQL command test for existing scenarios: (for System.Data.SqlClient) by default
• stop collecting command text for Microsoft.Data.SqlClient by default

[Dmitry-Matveev]

Looks good. Regarding defaults, can you please check with Dave? It may very well be a privacy requirement to have it opt-in only anyway (reqs recently were updated for several privacy considerations), in this case, yes, we're fixing a bug.

[stebet]

Distinguishing between the libraries in the collection logic would make it a bit more complicated as well, instead of just treating both libraries the same. Will look into it though if you want to split the default logic between the old and new library.

[TimothyMothra]

Adding a reminder here, we need to inform the support teams about this change. Although it's a bug, we're changing the default behavior and this may negatively impact customers.

[stebet]

Is there anything else needed from me on this PR? Any changes required?

[cijothomas]

@stebet nothing needed from you. We are discussing internally about the default setting. Will be back with finding here. (about whether we want sqltext ON by default or OFF by default)