Add metadata support - Githubissues

Expecho commented 4 years ago

Fix Issue #1287. Add support for reading Metadata from EventCounter payload.

Some thoughts:

I could write a unit test for it, but then the test project in EventCounterCollector.Tests needs to be .Net Core 3.0 instead of the current .Net Core 2.1
The metadata is stored in a simple string separated with ,. One could potentially add metadata with the characters , or : in either the name or the value messing things up. I find this unlikely but I do want to mention this.
We could just store the whole string in a telemetryitem property called "Metadata" but it makes it hard to use when consuming this metrics in Azure Monitor for example.

I tried to mimic the coding style of the rest of the file. If you want me to extract it to a separate method let me know.

cijothomas commented 4 years ago

Looks good! Can you add a one line description to the changelog.md as well? I will merge this for 2.12.0-beta2. https://github.com/microsoft/ApplicationInsights-dotnet-server/blob/develop/CHANGELOG.md

cijothomas commented 4 years ago

Manually kicked off CI build (its not triggered automatically for PRs from fork.). All good.

microsoft / ApplicationInsights-dotnet-server