microsoft / ApplicationInsights-dotnet

ApplicationInsights-dotnet
MIT License
566 stars 285 forks source link

Simplify Configuration of Advanced Options for Adaptive Sampling #2076

Open bdschaap opened 3 years ago

bdschaap commented 3 years ago

I would like to request that configuration of advanced options for Adaptive Sampling be simplified.

The current approach described here is different than configuration of other options which is described here. I would like to be able to configure the advanced options in a similar manner to the basic options.

cijothomas commented 3 years ago

ApplicationInsightsServiceOptions is intended to provide an ability to turn on/off some common feature. Its currently not intended to have all the settings for each feature. No investments are planned in this area in current year.

fschmied commented 3 years ago

I want to second this request by @bdschaap . It would be very useful to be able to configure these kinds of things via the configuration API - i.e., in the appsettings file or via environment variables. It's currently really easy to shoot yourself in the foot by reconfiguring adaptive sampling while forgetting to set EnableAdaptiveSampling to false, so that alone should justify adding these options to ApplicationInsightsServiceOptions. From the docs:

image

Also, these settings used to be configurable in ApplicationInsights.config, so it seems straight-forward that they should also be configurable via appsettings, doesn't it?

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 300 days with no activity. Remove stale label or this will be closed in 7 days. Commenting will instruct the bot to automatically remove the label.

fschmied commented 2 years ago

This is still an issue.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 300 days with no activity. Remove stale label or this will be closed in 7 days. Commenting will instruct the bot to automatically remove the label.

fschmied commented 1 year ago

It is still an issue.