microsoft / ApplicationInsights-dotnet

ApplicationInsights-dotnet
MIT License
565 stars 287 forks source link

Dependencies to unsupported and end of life nuget packages and frameworks #2850

Open antymon4o opened 9 months ago

antymon4o commented 9 months ago

Application Insights projects target frameworks net452 and net46 that are now not supported any more. List of currently supported framework versions can be seen at: https://dotnet.microsoft.com/en-us/learn/dotnet/what-is-dotnet-framework.

Additionally, the project Microsoft.ApplicationInsights.AspNetCore has a dependency on packages Microsoft.AspNetCore.Http and Microsoft.AspNetCore.Hosting that are deprecated. Not only these packages are deprecated, but the packages that these packages depend are also deprecated. This brings the implication that when some project depends on Microsoft.ApplicationInsights.AspNetCore version 2.22.0, then this project also gets the dependencies to packages that are deprecated and are no longer maintained.

The proposed solution for the first issue is to remove the unsupported targeted frameworks. For the deprecated AspNetCore packages, the proposal is to migrate the reference from nuget package to framework reference. This also requires a pop-up in the targeted framework from netstandard2.0 to net6.0.

MichaCo commented 8 months ago

Totally agree, but this is probably a duplicate of #2811

antymon4o commented 8 months ago

Yes, it seems so. I have already proposed a solution for these issues. The PR is waiting to be reviewed. I hope someone from the team will be able to look at it and after if some tunings are required, the issues can be resolved.