microsoft / ApplicationInsights-node.js

Microsoft Application Insights SDK for Node.js
MIT License
320 stars 138 forks source link

Redis information no longer showing up in Azure Portal #1207

Open skhilliard opened 9 months ago

skhilliard commented 9 months ago

We are using package versions...

"applicationinsights": "^2.7.0",
"applicationinsights-native-metrics": "^0.0.9",

...and have lately noticed that redis telemetry is no longer showing up in in the portal....is there something we need to do to correct this?

Portal Image

hectorhdzg commented 9 months ago

@skhilliard which version of redis npm package are you using?

skhilliard commented 9 months ago

@hectorhdzg "redis": "^4.6.7"

Thanks!

skhilliard commented 9 months ago

@hectorhdzg Good afternoon! I was just checking in to see if there was any other information that you require.

Thanks, Kelly

hectorhdzg commented 9 months ago

@skhilliard sorry for the delay, looks like version 4 is currently not supported in diagnostic-channel publishers we are using in the SDK, we are currently working on adopting OpenTelemetry in this SDK, latest code currently available in beta, I believe redis 4 is currently supported there

skhilliard commented 9 months ago

@hectorhdzg Thanks for the update! Any idea when this would be available in a release?

hectorhdzg commented 9 months ago

@skhilliard diagnostic channel publishers is in maintenance mode now and there is no plan to add support for newer versions of redis, you can use our new Azure Monitor OpenTelemetry solution to have support for latest versions of Redis https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/monitor/monitor-opentelemetry , you can also use beta version of this SDK if you need extra functionalities that are not available in other package.

skhilliard commented 9 months ago

@hectorhdzg Just to clarify....that means that the things we used to get by including the applicationinsights-native-metrics package will all eventually go away?

hectorhdzg commented 9 months ago

Native Metrics is a different package that generate extra metrics including information about JS Heap, Garbage Collection among others, this is something we want to include as a OpenTelemetry package, but the work hasn't started yet.

skhilliard commented 9 months ago

@hectorhdzg So, this is actually something that we are getting with the applicationinsights package if I understand you correctly? I do see its dependencies on some diagnostic channel and open telemetry packages.

    "node_modules/applicationinsights": {
      "version": "2.7.0",
      "resolved": https://registry.npmjs.org/applicationinsights/-/applicationinsights-2.7.0.tgz,
      "integrity": "sha512-/vV5X6M4TlRA5NxNZAdCE0gukzfK24mb3z18D5Kl/CyIfSVIkafsIji3mK+Zi5q+7dn6H1CkFazlcnLf40anHw==",
      "dependencies": {
        "@azure/core-auth": "^1.4.0",
        "@azure/core-rest-pipeline": "1.10.1",
        "@azure/core-util": "1.2.0",
        "@azure/opentelemetry-instrumentation-azure-sdk": "^1.0.0-beta.3",
        "@microsoft/applicationinsights-web-snippet": "^1.0.1",
        "@opentelemetry/api": "^1.0.4",
        "@opentelemetry/core": "^1.12.0",
        "@opentelemetry/sdk-trace-base": "^1.12.0",
        "@opentelemetry/semantic-conventions": "^1.12.0",
        "cls-hooked": "^4.2.2",
        "continuation-local-storage": "^3.2.1",
        "diagnostic-channel": "1.1.0",
        "diagnostic-channel-publishers": "1.0.6"
      },

If that is correct, does that mean that upcoming version of the applicationinsights package will include newer dependencies to open telemetry packages so this data will start showing up in the portal again?

Sorry for all this back and forth...

hectorhdzg commented 8 months ago

@skhilliard version 3.0.0 will in fact include support for latest Redis, we are targeting January for this release, but you should be able to get it now what I described before(beta or @azure package), this SDK will be using OpenTelemetry internally and all instrumentations supported there would be supported here, diagnostic channel had been in support mode only for a while now.

JacksonWeber commented 2 months ago

@skhilliard As version 3 has been released, you should have support for the latest Redis versions. Please let me know if the latest Application Insights package version works for your use case. Thank you!