search

microsoft / ApplicationInsights-node.js

Microsoft Application Insights SDK for Node.js
MIT License
321 stars 138 forks source link

[Beta] - Winston log level not respected by SDK #1294

Closed mderriey closed 2 months ago

mderriey commented 4 months ago

Hi there

We're using the SDK and using the Winston integration. We noticed, while the Winston logger level is set to info, that we get verbose logs emitted to App Insights.

We think we tracked this down to diagnostic-channel-publishers@1.0.7 not respecting the logger level and using the "max" level possible, in our case silly.

We saw you shipped diagnostic-channel-publishers@1.0.8 which seems to fix this issue.

Happy to open a PR if you agree this should be enough to correct this.

Cheers

JacksonWeber commented 2 months ago

@mderriey We're planning to move to an OpenTelemetry instrumentation for Winston soon and move away from the diagnostic-channel-publishers library. This issue should be resolved at that point. Thank you for the heads up!