search

microsoft / Appsample-Photosharing

Sample code for a UWP photo sharing app.
Other
287 stars 116 forks source link

AuthenticationProviders binding should not exist in SettingsPage.xaml #39

Open ToddBonnewell opened 7 years ago

ToddBonnewell commented 7 years ago

ItemsSource="{Binding AuthenticationProviders}" on line 43 of SettingsPage.xaml AND DebugPage.xaml line 45 should be removed. There is no AuthenticationProviders property in the corresponding ViewModels. My best guess is that these are artifacts of cut and paste. When running in Debug mode, the Diagnostics tool displays a few error events due to these bindings. No noticeable issues otherwise.

EricAtMSFT commented 7 years ago

Thanks Todd. We're bogged down at the moment but will likely address these after the holidays.