search

microsoft / AuthJanitor

Manage the lifecycle of application tokens, keys, and secrets in Azure
https://www.authjanitor.com
MIT License
45 stars 17 forks source link

Add provider feature flags, fill test gaps #67

Closed anthturner closed 4 years ago

anthturner commented 4 years ago

Related to #44

This starts us down the road of feature awareness for Providers. Most of the features given are already present (albeit nothing is functionally aware of these flags right now -- this PR is just for putting them in and displaying them on the Providers page) except for "Candidate Selection". This feature represents a future intent to allow Providers to enumerate possible candidate configurations instead of forcing the user to type it all out. This is especially useful since we already have OBO access from the admin in the intended installation scenario.

I also added some basic tests where there should have been some.

anthturner commented 4 years ago

Thought for the future...

Provider flags might be better served by interface inheritance, i.e. Providers inherit from ITestableProvider, IZeroDowntimeProvider, etc. I can't decide whether that would make certain workflows easier or more complicated to execute so I want to leave this in here at least for now as a placeholder for future goals.