search

microsoft / AuthJanitor

Manage the lifecycle of application tokens, keys, and secrets in Azure
https://www.authjanitor.com
MIT License
45 stars 17 forks source link

One-Key, Multiple-Apps Slottable Workflow calls Swap multiple times #90

Closed anthturner closed 4 years ago

anthturner commented 4 years ago

When committing one key to multiple locations in an application (for example, Azure Functions has 2 settings that must be changed together to prevent the runtime from failing) the swap is being called once for each instance of the configuration item, instead of committing everything altogether and running a single commit on the application.

This is a P0, as there are multiple things that require this type of interaction. I'm still shooting to make rotating an interlocked key with an Azure Functions app our gold standard for zero-downtime testing (for a number of reliability and stability reasons which make it more difficult) and that requires this.

anthturner commented 4 years ago

Idea on how to fix this... When implementing features, implement a feature called "RequiresUnifiedCommit" -- wherein all top-level types denoted with this feature are grouped together and Commit() is only called once for the type group.

anthturner commented 4 years ago

Fixed in #95