Check URLs starting with http or https when adding ShortURLs

microsoft / AzUrlShortener

An simple and easy Url Shortener

MIT License

518 stars 557 forks source link

Check URLs starting with http or https when adding ShortURLs #100

Closed fs366e2spm closed 4 years ago

fs366e2spm commented 4 years ago

Hi,

Discovered a strange behavior when I added some links. Missed that they didn't start with http or https but effect was, they weren't working, no redirect.

Either it should be checked during link creation that the Link starts with http(s) or the redirect should add it, if it's not available.

[x] add validation at creation time in the UI
[x] add validation at creation time in the UI

FBoucher commented 4 years ago

You are totally right @fs366e2spm this is a bug! Thank you for your help. TASKS: [ ] add validation at creation time in the UI [ ] add validation in the AzFunction and return a smart error message

FBoucher commented 4 years ago

@all-contributors add @fs366e2spm for bug, idea

allcontributors[bot] commented 4 years ago

@FBoucher

I've put up a pull request to add @fs366e2spm! :tada: