microsoft / AzUrlShortener

An simple and easy Url Shortener
MIT License
519 stars 561 forks source link

"Deploy to Azure" button fails #431

Closed solvaholic closed 1 year ago

solvaholic commented 1 year ago

👋 Hiyo! Thank you for this project @FBoucher :bow: I'm new to Azure Functions and look forward to learning from your work.

When I follow the Deploy to Azure button in doc/azFunctions-deployment.md, I encounter this error:

There was an error downloading the template from URI 'https://raw.githubusercontent.com/FBoucher/AzUrlShortener/vnext-v3/deployment/azureDeploy.json'. Ensure that the template is publicly accessible and that the publisher has enabled CORS policy on the endpoint. To deploy this template, download the template manually and paste the contents in the 'Build your own template in the editor' option below.

Replacing vnext-v3 with main in the link gets past the error, /cc #133 where I see a similar solution was applied before: https://portal.azure.com/?WT.mc_id=urlshortener-github-frbouche#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2FFBoucher%2FAzUrlShortener%2Fmain%2Fdeployment%2FazureDeploy.json

I think it looks like #429 set vnext-v3 for testing, in https://github.com/FBoucher/AzUrlShortener/commit/21286fba8dd80988d9012ea2eab692009c453c41.

To my mind, a user would want to deploy a tagged release rather than main, so I feel like users shouldn't be required to use the default branch name there. I'm still learning, tho, so I assume I don't see all the constraints involved.