search

microsoft / AzureSMR

AzureSMR is no longer being actively developed. For ongoing support of Azure in R, see: https://github.com/Azure/AzureR
Other
60 stars 43 forks source link

Connectors for ADLS New OAuth2.0 methods and code cleanup #104

Closed omkarksa closed 7 years ago

omkarksa commented 7 years ago

This incorporates changes of the previous pull request (https://github.com/Microsoft/AzureSMR/pull/103), that adds new OAuth2.0 methods to the existing AzureSMR auth framework. Also addresses several review comments and extensive code cleanup.

omkarksa commented 7 years ago

@andrie Please "Squash and merge" these changes once you are done with your review.

omkarksa commented 7 years ago

@richcalaway Could you please help review the changes before merge?

omkarksa commented 7 years ago

@richcalaway Please let me know if you need any info regarding these changes.

omkarksa commented 7 years ago

Thanks for pointing this out @inchiosa, @richcalaway I have addressed your CR comments and the pull request now includes the changes. Please check and let me know if is OK.

omkarksa commented 7 years ago

Thanks @inchiosa. I have addressed your CR comments. Please check and let me know if its OK.