search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
375 stars 86 forks source link

Pop up a confirmation dialog when opening a trusted file with name starting with whitespace #2857

Closed v-xianya closed 5 months ago

v-xianya commented 4 years ago

Storage Explorer Version: 1.13.0 Build: 20200418.1 Branch: rel/1.13.0 Platform/OS: Windows 10 Architecture: ia32 Regression From: Not a regression

Steps to reproduce:

  1. Launch Storage Explorer -> Settings.
  2. Go to Settings -> Transfers -> File Open -> Trusted File Extensions.
  3. Make sure the .txt extension is included in Trusted File Extensions.
  4. Expand one regular blob container -> Upload one .txt file with name starting with whitespace.
  5. Open the file -> Check the result.

Expect Experience: No dialog pops up.

Actual Experience: A confirmation dialog pops up. image

More Info: This issue doesn't reproduce for file shares.

MRayermannMSFT commented 4 years ago

@craxal ,can you figure out if this is not a regression of the setting based behavior vs not a regression of the non-setting based behavior of 1.12? If the behavior is exactly the same in 1.12, then we can fix this later.

v-xianya commented 4 years ago

@MRayermannMSFT This issue also reproduces in 1.12.0 release. Pop up the below dialog. image

craxal commented 4 years ago

Moved to 1.14.0 since this is not a regression.

craxal commented 4 years ago

I am unable to reproduce this in the 20200426.1 build.

v-xianya commented 4 years ago

Hi @craxal This issue still reproduces on build rel/1.13.0- 20200428.5.

Detail steps please see the record: https://web.microsoftstream.com/video/ce4da1ff-0400-96d0-8d5f-f1ea892d95ea

craxal commented 4 years ago

It appears that this bug is really a symptom of the way we treat blob/file transfers on Windows. For whatever reason, the path to the folder containing the downloaded file is passed to the function that checks for trusted file extensions, meaning Storage Explorer is trying to open the folder instead of the targeted file.

v-kellyluo commented 5 months ago

Verified this issue on the build 20240526.2. Fixed. So, we are going to close it. screen