search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
377 stars 86 forks source link

There is a failed activity log when transferring a blob folder with the source is the same as the destination #4667

Open v-xianya opened 3 years ago

v-xianya commented 3 years ago

Storage Explorer Version: 1.21.0-dev Build Number: 20210710.1 Branch: main Platform/OS: Windows 10/ Linux Ubuntu 18.04/ MacOS Big Sur 11.4 Architecture: ia32/x64 How Found: Exploratory testing Regression From: Previous release (1.20.0)

Steps to Reproduce

  1. Expand one storage account -> Blob Containers.
  2. Create a blob container -> Upload one non-empty folder.
  3. Select the folder -> Click 'Copy' -> Then click 'Paste'.
  4. Verify there is a waring activity log.

Expected Experience

There is a waring activity log. image

Actual Experience

There is a failed activity log. image

Here is the AzCopy log: 6e600c28-3f28-a048-6f1e-361925e10a35.log

Additional Context

  1. This issue reproduces for one ADLS Gen2 folder.
  2. For one empty ADLS Gen2 folder, there is a successful activity log. As below: image
JasonYeMSFT commented 3 years ago

We changed the way we construct AzCopy command which breaks our old logic for self copy checking. However, since AzCopy has added its own src/dst comparison, I think we should just get rid of our own checking logic and use theirs. AzCopy still needs to surface the error to us so we can have better error reporting.

v-xianya commented 3 years ago

This issue also reproduces for blobs/files on the build # 20210801.1.

JasonYeMSFT commented 3 years ago

@v-xianya I merged a fix to get rid of our logic for checking source and destination equivalence. Now for such type of transfers, we will always rely on AzCopy to fail and report the error. This will become the intended behavior but it can be improved if AzCopy can expose an error summary so we can display it in the activity.

The change also fixes https://github.com/microsoft/AzureStorageExplorer/issues/4737

v-xianya commented 3 years ago

@JasonYeMSFT we can get the failed reason (as below) from the AzCopy log. So are we going to keep the bug open until the error displays directly in the activity log? Transfer source and destination are the same, which would cause data loss. Aborting transfer

JasonYeMSFT commented 3 years ago

@v-xianya Yes.