search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
377 stars 86 forks source link

The action 'Undelete' is disabled when selecting more than one soft-deleted ADLS Gen2 blob snapshot #5443

Open v-xianya opened 2 years ago

v-xianya commented 2 years ago

Storage Explorer Version: 1.23.0-dev Build Number: 20220214.5 Branch: main Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Monterey 12.2 How Found: Ad-hoc testing Regression From: Not a regression

Steps to Reproduce

  1. Expand one ADLS Gen2 storage account -> Blob Containers.
  2. Create a blob container -> Upload one blob.
  3. Create two snapshots for the blob -> Soft delete the two blob snapshots.
  4. Select the two soft-deleted snapshots -> Open the context menu.
  5. Check whether the action 'Undelete' is enabled.

Expected Experience

The action 'Undelete' is enabled.

Actual Experience

The action 'Undelete' is disabled. image

JasonYeMSFT commented 2 years ago

This is by design. Undeleting any snapshot is equivalent to undeleting the base blob. There is no point undeleting two snapshots.

v-xianya commented 2 years ago

@JasonYeMSFT For soft-deleted regular blob snapshots, the 'Undelete' is enable for this scenario. It would be better to make the behavior consistent between regular blob container and ADLS Gen2 blob container. image

JasonYeMSFT commented 2 years ago

@v-xianya That makes sense. For non-gen2 we block undelete if there are deleted items with the same name. I need to make snapshots an exception.

For gen2 blobs, the work was blocked because the service hasn't implemented undelete for snapshots. I need to revisit https://github.com/microsoft/AzureStorageExplorer/issues/4670 to see if it's supported now.

JasonYeMSFT commented 2 years ago

It is still not possible for us to undelete individual snapshot items since we don't have their deletion id when listing. The deletion ids are available when we list without non-snapshots so I think this is still a service bug.

JasonYeMSFT commented 2 years ago

This is still not possible by 1.24.0. Moving to 1.25.0.

JasonYeMSFT commented 2 years ago

We are still not getting deletionIDs for gen2 blob snapshots.

v-xianya commented 8 months ago

Verified this issue on the rel 1.33.0 build 20240229.8. 'Undelete' action is enabled when selecting more than one soft-deleted ADLS Gen2 blob snapshots. So, we are going to close it. image

JasonYeMSFT commented 8 months ago

I verified this but I am seeing both undelete actions disabled, like issue #7781. Besides, undeleting snapshots still doesn't work because of the same reason I mentioned above.