microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
370 stars 84 forks source link

Ensure consistency of patterns/design in react explorer code, dedupe code where possible #7332

Open MRayermannMSFT opened 11 months ago

MRayermannMSFT commented 11 months ago

Now that the majority of explorers are migrated to react, let's go back through and make sure we are being consistent across each explorer with regards to patterns and designs. Additionally, let's reduce code duplication where possible. Areas initially thought of as warranty attention include:

Feel free to include/investigate additional areas.

For 1.33, please do independent investigation into coming up with actionable things we can do regarding this topic. After investigationg, discuss together and create engineering issues for 1.34.

### Areas of Improvement
- [ ] https://github.com/microsoft/AzureStorageExplorer/issues/7738
- [ ] https://github.com/microsoft/AzureStorageExplorer/issues/7737
- [ ] https://github.com/microsoft/AzureStorageExplorer/issues/7493
- [ ] Determine best format for HTML files, location of script tags
- [ ] #7526
- [ ] https://github.com/microsoft/AzureStorageExplorer/issues/7950
- [ ] https://github.com/microsoft/AzureStorageExplorer/issues/7508
JasonYeMSFT commented 10 months ago

Potential places that can be improved:

craxal commented 10 months ago

Let's move all suggestions to the first comment so we can keep them together in a task list.

JasonYeMSFT commented 6 months ago

The conclusion of a recent discussion is to implement a custom DataGridHook that can handle all the common logic for deriving props needed by DataGrid from the Explorer. The common logic include paging, selection, sorting, and data loading orchestration. This DataGridHook will help us de-duplicate code for these common logic in the existing explorers. Craig will work on a prototype in 1.34.0.

MRayermannMSFT commented 6 months ago

Main deliverable for 1.34: Share the data loading code/logic among our explorers:

craxal commented 4 months ago

Main deliverable for 1.34.0 is effectively done but untested. Pushing back due to higher-priority items.