search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
377 stars 86 forks source link

Replace iframe with `WebContensView` in Eula dialog #7774

Open JasonYeMSFT opened 8 months ago

JasonYeMSFT commented 8 months ago

There is a race condition in the Eula dialog code such that the color tokens for theming are not injected in the dialog. When this reproduces, the styling in the Eula dialog will be incorrect. This issue reproduces in 1.32.x.

JasonYeMSFT commented 8 months ago

The original bug has been fixed. However, concerns are raised since the iframe in the Eula dialog forces us to keep using inline scripts in the html file. We can consider switching to use webview to use a preload script to get rid of the need of the inline script.