search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
372 stars 85 forks source link

It would be better to use uncapitalized prepositions such as in "Organize by Resource Group" #7991

Closed v-xianya closed 2 months ago

v-xianya commented 3 months ago

Storage Explorer Version: 1.35.0-dev (98) Build Number: 20240607.1 Branch: main Platform/OS: Windows11/Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.5(Apple M1 Pro) Architecture: arm64/x64/x64/arm64 How Found: Ad-hoc testing Regression From: Not a regression

Steps to Reproduce

  1. Open ‘Settings -> Services'.
  2. Observe the setting 'Organize by Resource Group'.
  3. Check whether it shows 'By' in the description.

Expected Experience

It would be better to update 'by' to 'By'.

Actual Experience

It shows 'by' in the description. image

craxal commented 3 months ago

That is not correct usage. Unimportant words like prepositions are not typically capitalized unless they are at the beginning of a phrase.

v-xianya commented 3 months ago

Hi @craxal In the settings, other prepositions are capitalized; should we maintain consistency? image

v-xianya commented 3 months ago

Hi @craxal I think it would be better to maintain consistency for prepositions, so, we are going to re-open this issue.

craxal commented 3 months ago

Agreed. We will fix these strings.

v-kellyluo commented 2 months ago

Hi @craxal ,verified this issue on the build 20240716.5, the comments mentioned are fixed. But there are still some prepositions are capitalized, could you help to take a look? image

craxal commented 2 months ago

@v-kellyluo I was not aware you were referring to all prepositions. The bug only mentioned the use of the word "by". I can fix these as well.

craxal commented 2 months ago

Changes have been merged. Prepositions should have proper capitalization now. Please note, though that "Sign In With:" is now "Sign In with:". The word "in" is considered part of the "Sign In" feature and not quite a preposition, so it remains capitalized. However, "with" is a properly uncapitalized preopsition.

v-xianya commented 2 months ago

Verified this issue on the main build 20240723.1. The current behaviors match the comments.