microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
372 stars 85 forks source link

An extra scrollbar appears in the 'Manage Custom Environments' dialog if a custom environment with a long name is added #8007

Closed v-xianya closed 2 months ago

v-xianya commented 3 months ago

Storage Explorer Version: 1.35.0-dev (98) Build Number: 20240614.1 Branch: main Platform/OS: Windows11/Windows 10/Linux Ubuntu 22.04 & MacOS Sonoma 14.5(Apple M1 Pro) Architecture: arm64/x64/x64/arm64 How Found: Exploratory testing Regression From: Previous release (1.32.1)

Steps to Reproduce

  1. Open the connect dialog -> Click 'Subscription -> Custom Environment'.
  2. Click 'Manage custom environments...' -> Click 'Add'.
  3. Add one custom environment with a long name -> There is a scrollbar in the 'Custom environment' section.
  4. Click 'Back' -> Then click 'Manage custom environments...'.
  5. Check whether only the 'Custom environment' section has a scrollbar.

Expected Experience

Only the 'Custom environment' section has a scrollbar. image

Actual Experience

An extra scrollbar appears in the 'Manage Custom Environments' dialog. image

v-xianya commented 2 months ago

Verified this issue on the main build 20240716.5. Reproduce, so, we are going to reopen it. image

craxal commented 2 months ago

@v-xianya The ellipsis is intended. It is very, very unlikely a user is going to enter a name that long, so I do not believe anything else needs to be done.

v-xianya commented 2 months ago

Hi @craxal There is an extra scrollbar in the 'Manage Custom Environments' dialog. image

craxal commented 2 months ago

I've merged another fix to remove the scrollbar. The extra width was coming from the select element in the Select Azure Environment page. Please note that very long names will be cut off in the native menu that opens when clicking the select. As before, names this long is very, very unlikely for users, so we consider this expected behavior.

v-xianya commented 2 months ago

Verified this issue on the main build 20240724.1. Fixed. image