search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
368 stars 86 forks source link

The selected items are not highlighted if click 'Select All' on the view all containers toolbar #8044

Closed v-xianya closed 1 month ago

v-xianya commented 1 month ago

Storage Explorer Version: 1.35.0-dev (98) Build Number: 20240705.1 Branch: main Platform/OS: Windows11/Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.5(Apple M1 Pro) Architecture: arm64/x64/x64/arm64 How Found: From running test cases Regression From: Not a regression

Steps to Reproduce

  1. Expand one storage account -> Blob Containers.
  2. Create a blob container -> Right click the 'Blob Containers' node.
  3. Click 'View All' -> Click 'Select All' on the view all containers toolbar.
  4. Check whether the selected items are highlighted.

Expected Experience

The selected items are highlighted. image

Actual Experience

The selected items are not highlighted. image

craxal commented 1 month ago

@v-xianya The selected items are highlighted (see the gray background). The data grid just doesn't have focus (the "Select All" button does).

v-xianya commented 1 month ago

Hi @craxal For other explorer, the items will be highlighted as below after clicking 'Select All'. Also, there is a similar bug 7735. image

craxal commented 1 month ago

The real issue here appears to be whether the grid receives focus after clicking the Select All button, not whether the items are selected/highlighted.

v-xianya commented 1 month ago

Hi @craxal thank you for the response, I get your meaning. When clicking 'Select All' on view all containers explorer. The action select all is focused. When clicking 'Select All' on blob container explorer. The header of the grid is focused. I thought it would be much better to keep the two behaviors consistent. So, we are going to reopen this issue. image

craxal commented 1 month ago

After discussion, we agreed that keyboard focus should not move when clicking the button.

v-xianya commented 1 month ago

Verified this issue on the main build 20240717.2 The 'Select All' action is focused after clicking the button for all explorers. image