A refresh notification appears after an 'undelete by Date' activity is skipped with setting 'Auto Refresh on Change' unchecked

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.

Creative Commons Attribution 4.0 International

377 stars 87 forks source link

Storage Explorer Version: 1.36.0 (101) Build Number: 20241009.1 Branch: rel/1.36.0 Platform/OS: Windows 11/Windows 10/Linux Ubuntu 22.04/MacOS Sequoia 15.0(Apple M1 Pro) Architecture: arm64/x64/x64/arm64 How Found: Exploratory testing Regression From: Not a regression

Steps to Reproduce

Launch storage explorer -> Open Settings -> Uncheck the setting 'Auto Refresh on Change'.
Expand one storage account -> Blob Containers.
Create a blob container -> Upload one blob -> Soft delete the blob.
Go to 'Active and soft deleted blobs' -> Right click the soft deleted blob -> Click 'Undelete -> Undelete by Date...'.
Click 'OK' on the prompt dialog -> There is an activity log indicating that the undelete action was skipped.
Check whether no refresh notification appears.

Expected Experience

No refresh notification appears.

Actual Experience

A refresh notification appears.

Additonal Context

Fail to undelete the soft deleted blob, so it should not prompt a refresh notification.
There is no refresh notification if try to delete a blob with snapshots ( The option 'Also delete blob snapshots' is not checked.)

I'm going to consider this a Won't Fix, for the following reasons:

While it is true that skipped or failed items probably don't result in any changes to the server, the message is not necessarily wrong. The view may be out of date. This is especially true if the container is being modified by some other client. It's generally safer to assume a change may be possible even if nothing appears to have happened.
In most cases, I would expect there to be multiple operations and at least one of them to be successful. In this case, a change does happen.
The user can still opt out of the refresh if they want; it is unobtrusive.
Determining whether a notification should be shown or not increases complexity when very little is to be gained from it.

microsoft / AzureStorageExplorer