search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
377 stars 87 forks source link

It would be better to remove the term 'Visual Studio' from the content in the remove account confirmation dialog #8268

Closed v-xianya closed 2 weeks ago

v-xianya commented 3 weeks ago

Storage Explorer Version: 1.37.0-dev (102) Build Number: 20241028.13 Branch: hotfix/1.36.2 Platform/OS: Windows11/Linux Ubuntu 22.04/MacOS Sequoia 15.0(Apple M1 Pro) Architecture: arm64/x64/arm64 How Found: Exploratory testing Regression From: Not a regression

Steps to Reproduce

  1. Launch storage explorer -> Sign in with one Azure account.
  2. Go to the 'ACCOUNT MANAGEMENT' -> Click 'Remove'.
  3. A confirmation dialog pops up -> Observe the content in the dialog.

Expected Experience

It would be better to remove the term 'Visual Studio' from the content.

Actual Experience

The dialog currently displays 'Visual Studio' in its content. Image

craxal commented 3 weeks ago

I think this is by design. The identity service we use for authentication is the same service used by Visual Studio. If a user has Visual Studio installed, and the user signs out from Storage Explorer, that will sign them out of Visual Studio, too. So, we include this to let them know that.

v-xianya commented 3 weeks ago

Hi @craxal The comments make sense to me. However, there are some confusing aspects:

We tried having both Storage Explorer and Visual Studio installed. When we sign out from Storage Explorer, the account in Visual Studio remains signed in.

Similarly, if I sign out from Visual Studio, the account in Storage Explorer still stays signed in. here is the confirmation dialog when removing account from Visual Studio. Image

craxal commented 3 weeks ago

It seems you're right. Apparently, the association was severed some time ago. Storage Explorer and Visual Studio now have separate sign in collections. So, I think we can update the string.

v-xianya commented 2 weeks ago

Verified this issue on the main build 20241101.5. The term 'Visual Studio' has been removed. So, we are going to close it. Image