search

microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
377 stars 87 forks source link

The editors of restored tabs (except for the first tab) will display as blank if the tabs have a relevant parts of the node path #8273

Closed v-xianya closed 1 week ago

v-xianya commented 3 weeks ago

Storage Explorer Version: 1.37.0-dev (102) Build Number: 20241029.5 Branch: main Platform/OS: Windows 11/Windows 11/Linux Ubuntu 22.04/MacOS Sequoia 15.0(Apple M1 Pro) Architecture: arm64/x64/x64/arm64 How Found: Exploratory testing Regression From: Not a regression

Steps to Reproduce

  1. Launch Storage Explorer -> Make sure the setting 'Preserve Explorer Session' is checked.
  2. Expand one storage account -> Blob Containers.
  3. Select one blob container -> Pin it to Quick Access.
  4. Open the blob container and then open the QA blob container.
  5. Restart Storage Explorer.
  6. Check whether the editors of the restored tabs display correctly.

Expected Experience

The editors of the restored tabs display correctly.

Actual Experience

The editors of the restored tabs display as blank. Image

craxal commented 3 weeks ago

I have also noticed this with queue tabs.

v-xianya commented 3 weeks ago

Hi @craxal @richardMSFT

Today, we discovered that if there are two tabs with the same display name, all restored tabs except the first one will display as blank. This issue is a regression bug from version 1.35.0.

Image

craxal commented 2 weeks ago

In my case, I don't think any of the tabs have to have matching names. I've noticed it happens specifically to tables and queues.

@richardMSFT Let's make absolutely sure tab restoration is working correctly with or without differentiation data. Let's also make sure in upgrade scenarios that tabs aren't breaking.

maps-mike commented 2 weeks ago

Similar issue here - tabs blank possibly because my IP has changed & I no longer have access to a storage account due to storage firewall.

However, once my IP is added to the Storage firewall all preserved tabs remain blank - it feels like a refresh would resolve but the tool bar is not present on the blank tabs.

craxal commented 2 weeks ago

@maps-mike This is unrelated to your IP address changing or the need for a refresh. Can you verify the version of Storage Explorer you are using?

We looked into it and found a subtle bug in our UI code. We defer loading any panel UI for tabs until the tab is selected and its content is to be shown. A variable that triggers loading wasn't getting updated as expected, so the tab content wasn't getting loaded. Hence why the tab would appear blank.

The fix is relatively easy. We will update you on progress and when to expect a fix.

maps-mike commented 2 weeks ago

Awesome - glad its an easy fix!

Version 1.36.2 (103)

v-kellyluo commented 1 week ago

Verified this issue on the build hotfix/1.36.3 20241108.5. Fixed.