microsoft / AzureTRE-Deployment

MIT License
11 stars 22 forks source link

az acr login issue #85

Closed RIashfaqahmed closed 7 months ago

RIashfaqahmed commented 1 year ago

When deploying TRE, if an ACR is being created for the first time, the sleep time is not sufficient to wait until the ACR is fully created and ready for login.

for i in ***1..3***; do az acr login --name "***" && ec=0 && break || ec=\$? && sleep 10 done Error: Process completed with exit code 2.

marrobi commented 1 year ago

We've not seen this before, did the script work when run again?

RIashfaqahmed commented 1 year ago

When I re-run Deploy Azure TRE workflow, it worked and not raised this error again.

marrobi commented 1 year ago

Believe this is due to https://github.com/microsoft/AzureTRE-Deployment/pull/74/files#diff-5a2b3ccde8a4255fb43032fe938e96b572e2bee154824cab96b2027cb6a405c9R222 and need to ensure applied everywhere.

tim-allen-ck commented 7 months ago

A fix for this has been applied to the main branch, closing