search

microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
180 stars 138 forks source link

Verify that all TF Resources have costs tags in PR #2429

Closed guybartal closed 1 year ago

guybartal commented 2 years ago

Description

As a TRE Developer I need an automated solution which checks that all resources in Terraform has costs Tags so that I won't miss to tag any new/updated resource

tamirkamara commented 2 years ago

Worth to consider doing it here: https://github.com/terraform-linters/tflint-ruleset-azurerm/issues/133

guybartal commented 2 years ago

contributing a rule for azurerm tflinter ruleset which verifies if all taggable resources has a tag from a list of tags which can be configured for our case to have "tre_id" while ignoring the main ACR & storage would do the trick.

guybartal commented 2 years ago

https://github.com/terraform-linters/tflint-ruleset-azurerm/pull/194

guybartal commented 2 years ago

PR got merged and released in tflint-ruleset-azurerm v0.18.0, and requires tflint v0.40.0. waiting for a release of superliner to include that version of tflint.

marrobi commented 1 year ago

@guybartal this is now merged and in latest release https://github.com/github/super-linter/pull/3339