search

microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
170 stars 134 forks source link

Guacamole Shared drive always enabled. #3885

Open Danny-Cooke-CK opened 3 months ago

Danny-Cooke-CK commented 3 months ago

Describe the bug It appears that the guacamole share drive is always enabled regardless of what the "drive" option is set to. The setting in the workspace service is therefore not working. Porter has a default setting for drive which is set to "true" and it does not get overridden by the workspace drive setting

Steps to reproduce

  1. deploy a Guacamole with drive "False" (disabled) image
  2. Note that the Guacamole app service setting is Set to True image
  3. transfer on guacamole drive is available when it shouldn't be on the VM image

The same occurs when we set the drive to "true". it makes no difference.

Solution

  1. Set the drive option default to false in both the guacamole template and in the porter default
  2. set the drive option in the template to override the porter setting

Azure TRE release version (e.g. v0.16.0 or main):

tim-allen-ck commented 3 months ago

Hi @Danny-Cooke-CK thats definitely a bug, let me take a look through the code base and give you an update.