Closed tim-allen-ck closed 6 months ago
0 tests 0 :white_check_mark: 0s :stopwatch: 0 suites 0 :zzz: 0 files 0 :x:
Results for commit ffa1b3f0.
:recycle: This comment has been updated with latest results.
/test
:robot: pr-bot :robot:
:runner: Running tests: https://github.com/microsoft/AzureTRE/actions/runs/8567104061 (with refid fe1abbfe
)
(in response to this comment from @tim-allen-ck)
Are there any other actions that need doing?
Issue says: All actions are updated to their latest version
The Azure one was a note as to not forget it, apologies if confusing.
@tim-allen-ck suggest check the warnings at bottom of https://github.com/microsoft/AzureTRE/actions/runs/8540234100
@marrobi ahh okay, no problem, think I was confused. I'll take another look.
@marrobi just fyi technote-space/workflow-conclusion-action@v3 has been archived as of Nov 2023 and will not transition to node 20
@marrobi just fyi technote-space/workflow-conclusion-action@v3 has been archived as of Nov 2023 and will not transition to node 20
I'm not even sure its doing anything?
As its the same level as the step below.
@marrobi just fyi technote-space/workflow-conclusion-action@v3 has been archived as of Nov 2023 and will not transition to node 20
I'm not even sure its doing anything?
As its the same level as the step below.
Looks like its used to notify the teams channel of a failed run
@marrobi just fyi technote-space/workflow-conclusion-action@v3 has been archived as of Nov 2023 and will not transition to node 20
I'm not even sure its doing anything? https://github.com/microsoft/AzureTRE/blob/086be3308dfeadb61c3a086082da6bd7612bc5a9/.github/workflows/deploy_tre_reusable.yml#L812-L830
As its the same level as the step below.
Looks like its used to notify the teams channel of a failed run
That uses sachinkundu/ms-teams-notification@1.4
Not sure we use it either, and @sachinkundu has left MS, so might not be best to rely on that either. Can we delete the Teams notification piece for now.
@marrobi just fyi technote-space/workflow-conclusion-action@v3 has been archived as of Nov 2023 and will not transition to node 20
I'm not even sure its doing anything? https://github.com/microsoft/AzureTRE/blob/086be3308dfeadb61c3a086082da6bd7612bc5a9/.github/workflows/deploy_tre_reusable.yml#L812-L830
As its the same level as the step below.
Looks like its used to notify the teams channel of a failed run
That uses
sachinkundu/ms-teams-notification@1.4
Not sure we use it either, and @sachinkundu has left MS, so might not be best to rely on that either. Can we delete the Teams notification piece for now.
Yep let remove, I'll add an issue to replace it with something else
/test-extended
:robot: pr-bot :robot:
:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/8572145997 (with refid fe1abbfe
)
(in response to this comment from @tim-allen-ck)
/test
:robot: pr-bot :robot:
:runner: Running tests: https://github.com/microsoft/AzureTRE/actions/runs/8596920000 (with refid fe1abbfe
)
(in response to this comment from @tim-allen-ck)
Resolves #3847
What is being addressed
Some of the actions might stop working soon as they are based on Node16 which is being removed by Github.
How is this addressed
[x] All actions are updated to their latest version
Describe the changes made, and if appropriate, why they are addressed this way
Note any pending work (with links to the issues that will address them)
Update documentation
Update CHANGELOG.md if needed
Increment template version if needed, for guidelines see Authoring templates - versioning