search

microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
182 stars 139 forks source link

E2E tests can leave test services in the TRE, instead of cleaning up properly #3912

Closed TonyWildish-BH closed 5 months ago

TonyWildish-BH commented 5 months ago

Describe the bug After manually deploying the TRE and running the E2E tests, I have a working TRE, but there is a workspace service named 'DO NOT USE' that's in the menu (see screenshot). The E2E tests should clean that up, regardless of success or failure of the test.

Unfortunately, I don't have the output of that run on disk, so I can't give more information than that.

Steps to reproduce

  1. Deploy the TRE
  2. Run the E2E tests
  3. If you're (un)lucky, you'll find this vagrant service available to deploy.

Azure TRE release version (e.g. v0.14.0 or main): main

Deployed Azure TRE components - click the (i) in the UI: UI Version: 0.5.21 API Version: 0.18.5

Screenshot 2024-04-26 at 9 39 18 AM
marrobi commented 5 months ago

Hi Tony, we run automated end to end tests to validate and environment in the development process. We typically don't log into these environments, but if it does fail, things need to stay as they are so we can troubleshoot what happened. We then destroy the whole environment, using another command (can read here if interested https://github.com/microsoft/AzureTRE/blob/main/maintainers.md#pr-comment-bot-commands )

E2E tests should not be part of production deployment. That's why we have this repo - https://github.com/microsoft/AzureTRE-Deployment

TonyWildish-BH commented 5 months ago

OK, thanks, we can close this one.