search

microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
170 stars 134 forks source link

Airlock review VM creation requires SAS URL, but request does not provide one #3913

Open TonyWildish-BH opened 2 months ago

TonyWildish-BH commented 2 months ago

Describe the bug I have successfully made a few airlock import requests, and can see them in the TRE interface.

When I try to create a review VM for them, they require a SAS token to be able to access the data.

There seems to be no way to generate this SAS URL. The documentation shows a screen shot which has a 'generate' button (https://microsoft.github.io/AzureTRE/latest/using-tre/tre-for-research/review-airlock-request/), but the TRE I have deployed does not have that button (see screenshot).

Steps to reproduce

  1. Create an airlock import request,
  2. Attempt to create an airlock review VM,
  3. Fail, because you can't get a SAS URL to use to create the VM.

For bonus points, if you leave the SAS URL empty (it's optional in the interface), you don't get a complaint until it starts to deploy the service and fails several minutes later.

Azure TRE release version (e.g. v0.14.0 or main): main

Deployed Azure TRE components - click the (i) in the UI: UI Version: 0.5.21 API Version: 0.18.5

Screenshot 2024-04-26 at 5 12 25 PM
tim-allen-ck commented 2 months ago

Hi @TonyWildish-BH very odd, what permissions does your user have in that workspace?

TonyWildish-BH commented 2 months ago

Hi @tim-allen-ck. I have all roles; Owner, Research, and Airlock Manager

tim-allen-ck commented 2 months ago

Does the VM create?

TonyWildish-BH commented 2 months ago

No, it fails early with Error message: parameter "airlock_request_sas_url" is required, at the porter install step.

tim-allen-ck commented 2 months ago

I think that screenshot in the docs is out of date, I'm not sure that generate button doesn't exist to my knowledge. I'm assuming the airlock workspace is configured correctly too?

TonyWildish-BH commented 2 months ago

I don't have an airlock workspace, I'm creating an import review VM in Guacamole in the workspace I created the import request in.

akolensky commented 2 months ago

Hi Tony, this link should help: https://microsoft.github.io/AzureTRE/latest/tre-admins/configure-airlock-review/

I believe the documentation link in the post is oudated, but the one above should help. Following that process, it becomes possible to create Review VMs image

and then validate the data in the ReviewData folder image

tim-allen-ck commented 2 months ago

@TonyWildish-BH did the docs above help? can I close this issue?

TonyWildish-BH commented 2 months ago

hi @tim-allen-ck, I've been off for a while, and haven't had the chance to follow up on this yet, so please don't close it yet.