microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.

https://microsoft.github.io/AzureTRE

MIT License

170 stars 134 forks source link

Remove TLS1.0/1.1 support. Resolves #3914 #3916

Closed jonnyry closed 2 months ago

jonnyry commented 2 months ago

Resolves #3914

What is being addressed

Removes TLS1.0/1.1 support. Please see #3914.

How is this addressed

Explicitly sets the SSL policy within the App Gateway to the one currently recommended by Microsoft AppGwSslPolicy20220101.

As this was not explictly set in Terraform it was using an older AppGwSslPolicy20150501 which still supported TLS1.0/1.1. See the issue for more details on this.

Once deployed, the Azure TRE portal no longer reports running 1.0/1.1:

Capture

(Please see the issue for the "before" report)

@marrobi PR as discussed

github-actions[bot] commented 2 months ago

Unit Test Results

0 tests 0 :white_check_mark: 0s :stopwatch: 0 suites 0 :zzz: 0 files 0 :x:

Results for commit 9a88ade5.

:recycle: This comment has been updated with latest results.

jonnyry commented 2 months ago

Looks like its failing on a version check.

@tim-allen-ck Do I just bump this to 0.9.9?

Update - have submitted further commit to update the version number to 0.9.9, hope this is OK

marrobi commented 2 months ago

/test

github-actions[bot] commented 2 months ago

:robot: pr-bot :robot:

:warning: When using /test on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @marrobi)

marrobi commented 2 months ago

/test 9a88ade

github-actions[bot] commented 2 months ago

:robot: pr-bot :robot:

:runner: Running tests: https://github.com/microsoft/AzureTRE/actions/runs/8911967714 (with refid 57b3119d)

(in response to this comment from @marrobi)