Fix .github/workflows/lets_encrypt.yml

[jonnyry]

Resolves #3978

What is being addressed

See details of issue, but in summary to fix the lets_encrypt.yml GitHub Action:

• missing variable:
  • AZURE_ENVIRONMENT
• values of the following variables were the wrong way around:
  • ARM_SUBSCRIPTION_ID
  • ARM_TENANT_ID
• following variables needed passing in TF_VAR_varname form:
  • TERRAFORM_STATE_CONTAINER_NAME
  • MGMT_RESOURCE_GROUP_NAME
  • MGMT_STORAGE_ACCOUNT_NAME

In addition, the following minor changes were made:

1. Add an environment selector to the workflow_dispatch, to allow users to run for different environments other than CICD.
2. Commented out the schedule dispatch - I can see its perpetually failing on microsoft/AzureTRE, suggest its left up to forkers to determine whether to run on a schedule and for which environment? (though can re-introduce this if you think otherwise @marrobi @tim-allen-ck )

[github-actions[bot]]

Unit Test Results

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 083836fc.

:recycle: This comment has been updated with latest results.

[jonnyry]

Hi @tim-allen-ck @marrobi would it be possible to review & merge this (small) PR? thanks

[tim-allen-ck]

Hi @tim-allen-ck @marrobi would it be possible to review & merge this (small) PR? thanks

can update the CHANGELOG ?

[jonnyry]

@tim-allen-ck Added.

I also added an entry for the FIREWALL_SKU change, which I had missed.

[tim-allen-ck]

/test-force-approve

[github-actions[bot]]

:robot: pr-bot :robot:

:white_check_mark: Marking tests as complete (for commit 083836fcba7afdaa115beafc81b47aa5dcd52e7c)

(in response to this comment from @tim-allen-ck)