microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.

https://microsoft.github.io/AzureTRE

MIT License

182 stars 139 forks source link

Enable Workspace owners to create Airlock requests and remove need for email #3988

Closed marrobi closed 3 months ago

marrobi commented 3 months ago

Fixes #3904

This pull request introduces a new configuration variable, ENABLE_AIRLOCK_EMAIL_CHECK, which is set to false by default. When set to true, the system will require users to have an email address before creating an Airlock request. This change improves the default user experience and enables tests to be run by service prinicpals without an email address.

If the check is enable, Workspace Owners with addresses are now sufficient, not just resarchers.

github-actions[bot] commented 3 months ago

Unit Test Results

596 tests 594 :white_check_mark: 7s :stopwatch: 1 suites 2 :zzz: 1 files 0 :x:

Results for commit e25ad73b.

:recycle: This comment has been updated with latest results.

marrobi commented 3 months ago

/test-extended

github-actions[bot] commented 3 months ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/9596182083 (with refid fd13f46d)

(in response to this comment from @marrobi)

marrobi commented 3 months ago

/test-destroy-env

github-actions[bot] commented 3 months ago

Destroying PR test environment (RG: rg-trefd13f46d)... (run: https://github.com/microsoft/AzureTRE/actions/runs/9598581680)

github-actions[bot] commented 3 months ago

PR test environment destroy complete (RG: rg-trefd13f46d)

marrobi commented 3 months ago

/test-extended

github-actions[bot] commented 3 months ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/9599250505 (with refid fd13f46d)

(in response to this comment from @marrobi)

marrobi commented 3 months ago

LGTM, please add a test for the notifier

https://github.com/microsoft/AzureTRE/blob/1ffb09baf37f4599adfd65b4259fdda7564da408/api_app/event_grid/event_sender.py#L37

Added, probably should be at a lower level - event_sender, but easier to add here, seems to pass ok.

tim-allen-ck commented 3 months ago

/test

github-actions[bot] commented 3 months ago

:robot: pr-bot :robot:

:runner: Running tests: https://github.com/microsoft/AzureTRE/actions/runs/9615280394 (with refid fd13f46d)

(in response to this comment from @tim-allen-ck)

tim-allen-ck commented 3 months ago

/test-extended

github-actions[bot] commented 3 months ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/9616005621 (with refid fd13f46d)

(in response to this comment from @tim-allen-ck)

marrobi commented 3 months ago

/test-extended

github-actions[bot] commented 3 months ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/9619994874 (with refid fd13f46d)

(in response to this comment from @marrobi)

tim-allen-ck commented 3 months ago

/test-extended

github-actions[bot] commented 3 months ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/9642133620 (with refid fd13f46d)

(in response to this comment from @tim-allen-ck)

tim-allen-ck commented 3 months ago

/test-force-approve

github-actions[bot] commented 3 months ago

:robot: pr-bot :robot:

:white_check_mark: Marking tests as complete (for commit e25ad73b21dcf77a27f41d50fdfa4162d08db6f6)

(in response to this comment from @tim-allen-ck)