microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
169 stars 133 forks source link

MySQL Recreation Fix #3994

Closed tim-allen-ck closed 2 weeks ago

tim-allen-ck commented 2 weeks ago

Resolves #3993

What is being addressed

Added lifecycle rule for charset and collation to mysql resource to stop database recreating.

github-actions[bot] commented 2 weeks ago

Unit Test Results

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit e79bc0ea.

:recycle: This comment has been updated with latest results.

jonnyry commented 2 weeks ago

@tim-allen-ck any chance you could fix in the Gitea shared service template as well?

This is where I discovered it first (and what I'm trying to get working at the moment).

Thanks

marrobi commented 2 weeks ago

/test-force-approve

Not covered by tests

github-actions[bot] commented 2 weeks ago

:robot: pr-bot :robot:

:white_check_mark: Marking tests as complete (for commit 6d75b7f8900d723b3c6b3b5562694d2117bf58dd)

(in response to this comment from @marrobi)

jonnyry commented 2 weeks ago

Just tested the fix on my local instance - with Gitea rather than MySql component and still getting the issue:

image

For some reason its trying to force utf8mb4 back to utf8mb3, even though both are valid charsets.

I can't tell whether its terraform or Azure that is causing the conversion - had a brief look at terraform but couldn't see anything.

marrobi commented 2 weeks ago

Might be with adding an ignore_changes for those attributes of can't get it to settle.

tim-allen-ck commented 2 weeks ago

Might be with adding an ignore_changes for those attributes of can't get it to settle.

Changed to use a lifecycle rule, should cover newer versions of the charset/collation when they're introduced

tim-allen-ck commented 2 weeks ago

/test-force-approve

github-actions[bot] commented 2 weeks ago

:robot: pr-bot :robot:

:white_check_mark: Marking tests as complete (for commit 7152380b5a992d956c8f9bfe0c19df6c9803472f)

(in response to this comment from @tim-allen-ck)

tim-allen-ck commented 2 weeks ago

@jonnyry added fixes for gitea

tim-allen-ck commented 2 weeks ago

/test-force-approve

github-actions[bot] commented 2 weeks ago

:robot: pr-bot :robot:

:white_check_mark: Marking tests as complete (for commit e79bc0eabc4c4d3113c84f591d8e7e34aa6d7745)

(in response to this comment from @tim-allen-ck)