microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.

https://microsoft.github.io/AzureTRE

MIT License

185 stars 145 forks source link

Update local debugging for RBAC key vaults #4133

Closed tim-allen-ck closed 2 weeks ago

tim-allen-ck commented 2 weeks ago

Resolves #4000

What is being addressed

Missed key vault policy in setup_local_debugging.sh

How is this addressed

keyvault_resource_id output added in core
script changed to add user as Key Vault Secrets User

github-actions[bot] commented 2 weeks ago

Unit Test Results

0 tests 0 ✅ 0s ⏱️ 0 suites 0 💤 0 files 0 ❌

Results for commit b2ecc126.

:recycle: This comment has been updated with latest results.

tim-allen-ck commented 2 weeks ago

LGTM, you could get the keyvault resource ID, from the keyvault_name that already exists in the outputs via the CLI?

az keyvault show -n kv-mr0110-ws-d8ab --query id

yeah I thought about that, figured it was an unnecessary az command when we can get it from the tf

tim-allen-ck commented 2 weeks ago

/test-force-approve

github-actions[bot] commented 2 weeks ago

:robot: pr-bot :robot:

:white_check_mark: Marking tests as complete (for commit b2ecc1266d93ae61cd753a1607135cd518832097)

(in response to this comment from @tim-allen-ck)