fix src/k4a_ros_device.cpp rclcpp::Duration(double) - Githubissues

microsoft / Azure_Kinect_ROS_Driver

A ROS sensor driver for the Azure Kinect Developer Kit.

MIT License

304 stars 226 forks source link

fix src/k4a_ros_device.cpp rclcpp::Duration(double) #275

Open soeroesg opened 1 year ago

soeroesg commented 1 year ago

Fixes

Fixes #270

fix src/k4a_ros_device.cpp rclcpp::Duration(double)

Description of the changes:

rclcpp::Duration(double) does not exist in ROS humble, instead we can use rclcpp::Duration::from_seconds())

Required before submitting a Pull Request:

[x] I reviewed CONTRIBUTING.md
[x] I built my changes locally
[x] I tested my changes with a device
[x] I changed both the ROS1 and ROS2 branches (the change only applies to ROS2)

I tested changes on:

[x] Windows (I have no ROS on Windows but the change is minimal)
[x] Linux
[x] ROS1 (no change needed)
[x] ROS2

Thaina commented 8 months ago

Same here on kinect k4a sample for unity. Can it be used the same fix?