search

microsoft / BCApps

Repository for collaboration on Microsoft Dynamics 365 Business Central applications.
https://microsoft.github.io/BCApps/
MIT License
299 stars 143 forks source link

#1855 Base64 convert for secret text #1857

Closed TKapitan closed 3 weeks ago

TKapitan commented 3 weeks ago

Summary

Adds support for base64 for secrettexts

Work Item(s)

Fixes #1855 Fixes AB#545707

TKapitan commented 3 weeks ago

@BazookaMusic @pri-kise @darjoo @JesperSchulz @WaelAbuSeada

Can you please have a look? This is quite critical for our extensions as without this we will need to revert all our changes we did in past month and return back to standard text implementation.

Let me know if you see any issues with this design, but as it returns again everything as secret text I don't see any issues as of now.

JesperSchulz commented 3 weeks ago

@BazookaMusic @pri-kise @darjoo @JesperSchulz @WaelAbuSeada

Can you please have a look? This is quite critical for our extensions as without this we will need to revert all our changes we did in past month and return back to standard text implementation.

Let me know if you see any issues with this design, but as it returns again everything as secret text I don't see any issues as of now.

On it! I'll get this signed off today, in time for release with 25.0.

JesperSchulz commented 3 weeks ago

Waiting to merge until we have a DevOps work item available.