microsoft / BatteryML

MIT License
480 stars 101 forks source link

Is dataprepare.md outdated? #40

Closed MarkVeerasingam closed 2 months ago

MarkVeerasingam commented 3 months ago

Hi all, been looking to use batteryML for some time now and excited now that i have the time! :)

I was reading through your readme and dataprepare markdown files.

I noticed some minor differences between the recently updated readme and the dated dataprepare markdowns, when following the MATR dataset preprocess documentation.

I assume python scripts/preprocess.py from the datapreprocess.md is meant to be python preprocess/preprocess_MATR.py

there is also the absence of the batteryml download MATR /path/to/save/raw/data that was recently added to the readMe.

I am currently following the setup in the readme but just want to make sure the way I currently am setting up is the intended way :)

fingertap commented 2 months ago

Yes. You should follow the instructions in readme~