microsoft / BatteryML

MIT License
516 stars 109 forks source link

fix bug in preprocessing HNEI dataset #49

Closed Ruifeng-Tan closed 1 month ago

Ruifeng-Tan commented 3 months ago

I identified an issue with the original code that processes HNEI data, where the time series data is incorrectly sorted based on the Cycle_Index. This sorting disrupts the original order of the experimental current-voltage profile, leading to anomalies such as an unrealistic increase and sudden decrease in capacity, which occur in tandem with a decreasing recorded time (as shown in the attached figure).

By instead sorting the time series based on Test_Time (s), this bug is resolved. Additionally, I suspect that similar issues might exist in the preprocessing of other datasets, such as the OX dataset. This bug could potentially affect reported model performances, so it is recommended to further investigate and address this in related preprocessing scripts.

Sort_error