check for build requirements and abort build process if not satisfied

microsoft / BitNet

Official inference framework for 1-bit LLMs

MIT License

11.44k stars 774 forks source link

check for build requirements and abort build process if not satisfied #38

Open bmerkle opened 1 month ago

bmerkle commented 1 month ago

python>=3.9
cmake>=3.22
clang>=18 on windows use the msvc-clang (>=17)

fix https://github.com/microsoft/BitNet/issues/34

bmerkle commented 2 weeks ago

@potassiummmm can you have a look at this? IMO checking for prerequisites will avoid a lot of user bug reports 😉.

bmerkle commented 2 weeks ago

merge conflict resolved

potassiummmm commented 2 weeks ago

Thanks for your work! We are working on resolving toolchain dependencies, so the current version limitations may not be mandatory.

bmerkle commented 1 week ago

@potassiummmm I understand. However in our build environment / embedded area we usually check for tool names and also tool versions, so IMO we are on a safer side if we check it (at least the minimal required versions). And the implementation is already there with this patch/PR :-) What do you think ?