search

microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.32k stars 4.85k forks source link

[ARM Templates] Add parameter for Gov deployments #1631

Open stevengum opened 5 years ago

stevengum commented 5 years ago

Is your feature request related to a problem? Please describe. Add parameter to specify if deployment is for Public Azure or US Gov Cloud.

Describe the solution you'd like Since only one sovereign/national cloud is currently supported by Azure Bot Service, add a flag that toggles the specific environment variable/Application Setting (Azure Web Apps) that needs to be configured for an US Gov bot to work correctly. (Authentication with a non-public Azure App Registration)

Describe alternatives you've considered Documenting how to set the required Gov cloud setting, which would add more for a user to read and another command for the user to run before the can successfully deploy their bot to Gov. This would provide a noticably difference in UX for US Gov vs Public Azure users.

In the future, this setting should probably be an enum, and an object variable in the ARM template would be used to verify/get the actual value for the Application Setting (e.g. "usgov" == "https://botframework.azure.us")

Note: for Public Cloud, there is no setting that needs to be set.

[enhancement]

cleemullins commented 4 years ago

Pushing to 4.7.

stevengum commented 4 years ago

Still little-to-no interest and not directly reliant on shipping out directly in R7. Pushing out to R8.