microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.35k stars 4.86k forks source link

Wrong order of bot responses #1983

Closed turbozapekanka closed 4 years ago

turbozapekanka commented 4 years ago

I'm using Core bot template After confirming the flight booking bot responses with confirmation and prompt for a new input. The order is reversed. Please see the screenshot This only happen once so I can't reproduce this.

bot answers wrong order

turbozapekanka commented 4 years ago

Not sure if this is a sample bug or framework issue.

EricDahlvang commented 4 years ago

Hi @turbozapekanka

That is strange! Which version of WebChat is the above example using? This must be a race condition on the client. Please upgrade WebChat to the latest, and let us know if that resolves the issue.

turbozapekanka commented 4 years ago

I simply copied and pasted the example iframe code from the web chat channel configuration: I have no idea what version of WebChat this is running.

EricDahlvang commented 4 years ago

That embed link is the V3 WebChat (the portal is a little behind). More information on embed links can be found here: https://github.com/microsoft/BotFramework-WebChat/blob/master/packages/embed/README.md#how-to-use

Please try out the Gemini embed link, which is WebChat V4:

https://webchat.botframework.com/embed/b/gemini?s=YourWebchatSecret&b=YourBotHandle

CoHealer commented 4 years ago

@turbozapekanka have you tried the V4 embed link? Do you still have the reversing issue?

turbozapekanka commented 4 years ago

Yes i tried, but I could not reproduce this issue neither with v3 nor with v4 I can only guess that first response was re-transmitted because of some underlying network issue, and thus it ended up received after the second response. But I have no idea how to reproduce this. I don't know if there are any mechanisms in place in the bot framework that ensures correct order of messages.

EricDahlvang commented 4 years ago

@turbozapekanka We are going to close this as not reproducible. Please open a new issue if you run into any other problems.