search

microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.34k stars 4.87k forks source link

Call BotFrameworkAdapter.useWebSockets() when the upgrade request hits the messaging endpoint #2196

Open stevengum opened 4 years ago

stevengum commented 4 years ago

Sample information

  1. Sample type: samples\
  2. Sample language: [Node.js and TypeScript]
  3. Sample name: Samples that use WebSockets for Direct Line Speech

Describe the bug

Add the logic to samples so that it only processes any Upgrade requests against its messaging endpoint.

Expected behavior

Any Upgrade requests should not be automatically processed unless against the messaging endpoint.

Either we change the samples to track the correct messaging endpoint, or we add comments to indicate to developers that their bots should only attempt the Upgrade request when it receives the request against its messaging endpoint.

[bug]

stevengum commented 4 years ago

Derived from https://github.com/microsoft/botbuilder-js/issues/1387.