microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.35k stars 4.87k forks source link

CancelAllDialogs mechanism in Skills CoreBot #2204

Open axelsrz opened 4 years ago

axelsrz commented 4 years ago

The current behavior for Skill Core Bot considers cancelling all dialogs bottom-up, C# does provide this mechanism due to changes done for adaptive (DialogContainers, Dialog.Child property, CancelAllDialogsAsync bottom up, etc), but neither Python nor JS have ported those changes yet.

We should make a decision regarding what pattern to show in the samples to address this scenario in the missing languages.

stevengum commented 4 years ago

Moved this to R10 for triage discussions.

gabog commented 4 years ago

@axelsrz. @stevengum, what do we need to decide if we take this in R11 or not?

axelsrz commented 3 years ago

This change will ship with DialogManager changes