search

microsoft / BotBuilder-Samples

Welcome to the Bot Framework samples repository. Here you will find task-focused samples in C#, JavaScript/TypeScript, and Python to help you get started with the Bot Framework SDK!
https://github.com/Microsoft/botframework
MIT License
4.35k stars 4.87k forks source link

Proactive C# sample needs to stop sending mock appId #2883

Open johnataylor opened 3 years ago

johnataylor commented 3 years ago

The current proactive sample in C# sends a mock appId (its actually a new GUID)

This only ever worked because we had a check in the AppCredentials implementation that looked in the trusted service url collection. Now we have removed that check this samples was broken.

To do anonymous auth the sample should make the appId null.

See also:

https://github.com/microsoft/botbuilder-dotnet/pull/4891

johnataylor commented 3 years ago

@stevkan note the change we need to make to the sample when we have @EricDahlvang fix in a package.